Re: [alsa-devel] [WIP PATCH] Scarlett mixer interface for 6i6, 18i6, 18i8 and 18i20.

At Wed, 08 Oct 2014 21:04:06 +0200, Daniel Mack wrote:

...

• if (ret < 0) {

+error:

• snd_printk(KERN_ERR "cannot get ctl value: req = %#x, wValue = %#x, wIndex = %#x, size = %d\n",
  

• 	   bRequest, wValue, idx, size);
  

• return ret;
  

• }

+#if 0 /* rg debug XXX */

• snd_printk(KERN_ERR "req ctl value: req = %#x, rtype = %#x, wValue = %#x, wIndex = %#x, size = %d\n",

•    bRequest, (USB_RECIP_INTERFACE | USB_TYPE_CLASS | USB_DIR_IN), wValue, idx, size);
  

+#endif

That can be moved to snd_printdd()

We've been moving from snd_print*() to dev_*() recently, so try to use dev_dbg() here. Also, for other use of printk (or snd_printk() etc), try to convert to dev_info(), dev_err(), etc, appropriately.

thanks,

Takashi