On Fri, Jul 26, 2013 at 12:02:51PM -0700, Felipe Tonello wrote:
On Fri, Jul 26, 2013 at 11:56 AM, Mark Brown broonie@kernel.org wrote:
snd_jack_new(chip->card, "Headphone",
SND_JACK_HEADPHONE, &data->hp_jack);
SND_JACK_HEADPHONE, 0, &data->hp_jack); xonar_ds_handle_hp_jack(chip);
...this really ought to be done as part of the commit that adds the parameter since it breaks the build until this patch is applied.
But that's why is a patch series. But as you say, are you suggesting me to propose this changes in one patch only?
This one should be squashed in, as should the part of the ASoC change that adjusts for the call into the core API. The general idea with a patch series is to split things into smaller chunks so they're easier to understand and review but still keep things working with each change so that things like git bisect continue to be usable.
So I guess something like one patch that changes the core jack API to add the index and support jack creation, one to remove the HDA custom implementation and one to add support for specifying the index to the ASoC API and adjust all its users.