On 09/02/2014 09:13 AM, Ulf Hansson wrote:
On 1 September 2014 17:32, Tomeu Vizoso tomeu.vizoso@collabora.com wrote:
In preparation to change the public API to return a per-user clk structure, remove any usage of this public API from the clock implementations.
The reason for having this in a separate commit from the one that introduces the implementation of the new functions is to separate the changes generated with Coccinelle from the rest, and keep the patches' size reasonable.
Signed-off-by: Tomeu Vizoso tomeu.vizoso@collabora.com Tested-by: Boris Brezillon boris.brezillon@free-electrons.com Tested-by: Heiko Stuebner heiko@sntech.de Acked-by: Boris Brezillon boris.brezillon@free-electrons.com
Hi Tomeu,
Huh, what a patch. :-) Great work you are doing here!
Thanks!
By just looking at the ux500 changes, I realize that you now have removed the dependency to "struct clk", thus we shouldn't include the header file linux/clk.h in any file located in driver/clk/ux500/*, right!?
I suppose this comment may also applicable for others than the ux500 clk driver, but haven't checked.
You are right. I have gone ahead and removed the include from all files that are fed to the coccinelle script. Everything builds fine in all configurations I have tested, so I will be adding it to v9.
Thanks for the idea,
Tomeu
Kind regards Uffe