-----Original Message----- From: Mark Brown broonie@kernel.org Sent: Tuesday, 4 August, 2020 7:50 PM To: Sit, Michael Wei Hong michael.wei.hong.sit@intel.com Cc: alsa-devel@alsa-project.org; tiwai@suse.com; pierre- louis.bossart@linux.intel.com; Rojewski, Cezary cezary.rojewski@intel.com; Shevchenko, Andriy andriy.shevchenko@intel.com; liam.r.girdwood@linux.intel.com; Sia, Jee Heng jee.heng.sia@intel.com Subject: Re: [PATCH 4/4] dt-bindings: sound: intel,keembay-i2s: Add channel-max property
On Tue, Aug 04, 2020 at 01:57:23AM +0000, Sit, Michael Wei Hong wrote:
The platform also has 2 different interfaces which have
different
supported max-channels.
Using this value in the device-tree to determine the maximum
supported channel of the interface.
These should have different compatible strings, there are likely further differences between them (even if they are not currently documented).
The 2 different I2S ports are from the same SoC which supports different number of channels, do we need different compatible
strings for this?
Considering the only difference is the maximum supported
channels is 8 and 2?
Are you *sure* that's the only difference, or is that just the only difference you know about right now?
Yes, I am fairy sure that is the only difference according to the design, as per the platform use case.