* Mark Brown broonie@kernel.org [180219 12:05]:
On Fri, Feb 16, 2018 at 07:57:07AM -0800, Tony Lindgren wrote:
One advantage of using a compatible property for the pmic subdevices though is that it leaves out a dependency between various device drivers things happen automagically. The mfd core driver can be minimal and just implement interrupt handling and regmap. So no need to to parse the child nodes in the pmic mfd driver :)
There's no need to do that anyway - with a MFD the child devices can assume that they're part of the MFD and reference their parent.
So personally I'd prefer the option that requires least amount of custom code if compatible vs no compatible property is the only issue here.
It's a few lines of code to register the child devices from code rather than the DT, and keeps it out of the ABI.
OK yeah that's a good point with avoiding the ABI. Seems we still want the dts child node(s) though. That way audio device can be disabled for devices where audio is not wired up at all on this PMIC.
Regards,
Tony