On 01/27/2015 08:40 AM, Kuninori Morimoto wrote:
Hi Lars
Thank you for your patch
The DAI link format should be specified for the whole link rather than just one component on the link. So move the format specification for the HDMI audio link from the CPU component to the link itself.
Since the sh-mobile-hdmi DAI driver doesn't implement the set_fmt() callback in this case there is no functional difference between only specifying the the format for the CPU side or for the whole link, but the later it will allow us to remove support for just specifying the format for one component.
Signed-off-by: Lars-Peter Clausen lars@metafoo.de
No changes since v1.
arch/arm/mach-shmobile/board-armadillo800eva.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c index 6d949f1..75de26c 100644 --- a/arch/arm/mach-shmobile/board-armadillo800eva.c +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c @@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = { .card = "FSI2B-HDMI", .codec = "sh-mobile-hdmi", .platform = "sh_fsi2",
- .daifmt = SND_SOC_DAIFMT_CBS_CFS, .cpu_dai = { .name = "fsib-dai",
.fmt = SND_SOC_DAIFMT_CBS_CFS,I guess if you want to use common .daifmt, it should be same as "codec" side. (cpu side "S" means, codec / daifmt side "M") So, this mean above should be
@@ -1040,9 +1040,9 @@ static struct asoc_simple_card_info fsi2_hdmi_info = { .card = "FSI2B-HDMI", .codec = "sh-mobile-hdmi", .platform = "sh_fsi2",
- .daifmt = SND_SOC_DAIFMT_CBM_CFM, <= .cpu_dai = { .name = "fsib-dai",
.fmt = SND_SOC_DAIFMT_CBS_CFS,
Right now the CPU is configured as master, with your proposed change it would be configured as slave. These flags are always from the CODEC's perspective.