Re: [alsa-devel] [PATCH 10/24] ALSA: au1x00: convert to platform device

2014-02-12 11:35 GMT+01:00 Takashi Iwai tiwai@suse.de:

From: Manuel Lauss mano@roarinelk.homelinux.net

[...]

--- a/sound/mips/au1x00.c +++ b/sound/mips/au1x00.c

[...]

-static int __init -au1000_init(void) +static int au1000_ac97_probe(struct platform_device *pdev) {

[...]

+out3:

•   kfree(au1000->stream[PLAYBACK]);
  

+out2:

•   kfree(au1000->stream[PLAYBACK]);
  

+out1:

[...]

This looks bad. Maybe it could use devm_*() functions?

Best Regards, Michał Mirosław