7 Mar
2015
7 Mar
'15
11:45 a.m.
On Fri, Mar 06, 2015 at 03:49:39PM -0700, Eric Nelson wrote:
Based on your review, it seems like the following is needed for a V2 patch (set):
- Move call to sgtl5000_fill_defaults() earlier in the sgtl5000_i2c_probe routine, before adjusting ANA_POWER. This will allow registers LINEREG_CTRL, CLK_CTRL, and even ANA_POWER back into the default register list.
I think that whole area of code also needs some revisions to make the code look like it's doing what it's supposed to be doing - the fact that it is described as register defaults at the minute but aren't really what a driver would normally mean by register defaults seems to be a big source of confusion.
Let me know if you'd like to see this in multiple patches or a single patch.
Definitely multiple patches, the level of splitting you've got now is pretty good.