24 Feb
2009
24 Feb
'09
7:46 p.m.
On Tue, Feb 24, 2009 at 11:37:47AM -0600, Lopez Cruz, Misael wrote:
About adding GPIO functionality to jack detection, if the right place to request GPIOs and set its data direction is in board files (arch/*/mach-*/board-*.c), then there won't be much to do in jack code, only the irq request. Unless we move request and data direction setting to jack detection layer.
No, do that in the jack code. The board code should only be doing things like putting the pins into GPIO mode (if that's not the default) and any other steps required to ensure that they don't do anything like consume a lot of power without the audio driver loaded.