Re: [alsa-devel] [PATCH] ASoC: rt5677: Add the slot_width "25" support in the TDM mode

On Mon, Jan 12, 2015 at 01:34:55PM +0800, Oder Chiou wrote:

Add the slot_width "25" support in the TDM mode for the Intel platform.

case RT5677_AIF2: snd_soc_update_bits(codec, RT5677_TDM2_CTRL1, 0x1f00, val);

• if (slot_width == 25)
  

• 	snd_soc_update_bits(codec, RT5677_DIG_MISC, 0x80, 0x80);
  

  break;

This looks good but I'd expect to see something which clears this bit if we're not using a slot width of 25 in case someone comes up with a use case that changes formats at runtime (relatively unlikely, but better safe than sorry).