Hi Herve,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on broonie-sound/for-next] [also build test ERROR on robh/for-next powerpc/next powerpc/fixes linus/master v6.2-rc2 next-20230106] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Herve-Codina/dt-bindings-soc-... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230106132951.392271-3-herve.codina%40bootlin.com patch subject: [PATCH 02/10] soc: fsl: qe: Add support for TSA config: alpha-allmodconfig compiler: alpha-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/2f330c694ec5018a16972be5314997... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Herve-Codina/dt-bindings-soc-fsl-cpm_qe-Add-TSA-controller/20230106-213320 git checkout 2f330c694ec5018a16972be5314997b4da85385a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/soc/fsl/qe/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/soc/fsl/qe/tsa.c: In function 'tsa_connect': drivers/soc/fsl/qe/tsa.c:149:9: error: implicit declaration of function 'clrsetbits_be32' [-Werror=implicit-function-declaration] 149 | clrsetbits_be32(tsa->si_regs + TSA_SICR, clear, set); | ^~~~~~~~~~~~~~~ drivers/soc/fsl/qe/tsa.c: In function 'tsa_add_entry': drivers/soc/fsl/qe/tsa.c:288:17: error: implicit declaration of function 'clrbits32' [-Werror=implicit-function-declaration] 288 | clrbits32(area->last_entry, TSA_SIRAM_ENTRY_LAST); | ^~~~~~~~~
drivers/soc/fsl/qe/tsa.c:304:17: error: implicit declaration of function 'out_be32' [-Werror=implicit-function-declaration]
304 | out_be32(addr, val); | ^~~~~~~~ drivers/soc/fsl/qe/tsa.c: In function 'tsa_probe':
drivers/soc/fsl/qe/tsa.c:667:9: error: implicit declaration of function 'out_8' [-Werror=implicit-function-declaration]
667 | out_8(tsa->si_regs + TSA_SIGMR, val); | ^~~~~ cc1: some warnings being treated as errors
vim +/out_be32 +304 drivers/soc/fsl/qe/tsa.c
268 269 static int tsa_add_entry(struct tsa *tsa, struct tsa_entries_area *area, 270 u32 count, u32 cell_id, u32 flags) 271 { 272 void *__iomem addr; 273 u32 left; 274 u32 val; 275 u32 cnt; 276 u32 nb; 277 278 addr = area->last_entry ? area->last_entry + 4 : area->entries_start; 279 280 nb = DIV_ROUND_UP(count, 8); 281 if ((addr + (nb * 4)) > area->entries_next) { 282 dev_err(tsa->dev, "si ram area full\n"); 283 return -ENOSPC; 284 } 285 286 if (area->last_entry) { 287 /* Clear last flag */ 288 clrbits32(area->last_entry, TSA_SIRAM_ENTRY_LAST); 289 } 290 291 left = count; 292 while (left) { 293 val = TSA_SIRAM_ENTRY_BYTE | tsa_cell_id2csel(tsa, cell_id); 294 295 if (left > 16) { 296 cnt = 16; 297 } else { 298 cnt = left; 299 val |= TSA_SIRAM_ENTRY_LAST; 300 area->last_entry = addr; 301 } 302 val |= TSA_SIRAM_ENTRY_CNT(cnt - 1); 303
304 out_be32(addr, val);
305 addr += 4; 306 left -= cnt; 307 } 308 309 return 0; 310 } 311