-----Original Message----- From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com Sent: Saturday, February 27, 2021 5:48 AM To: Jack Yu jack.yu@realtek.com; broonie@kernel.org; lgirdwood@gmail.com Cc: Oder Chiou oder_chiou@realtek.com; alsa-devel@alsa-project.org; lars@metafoo.de; kent_chen@realtek.com [陳建宏] kent_chen@realtek.com; 陳昶志 kenny_chen@realtek.com; Derek [方德 義] derek.fang@realtek.com; Shuming [范書銘] shumingf@realtek.com; Flove(HsinFu) flove@realtek.com Subject: Re: [PATCH] ASoC: rt1015p: add acpi device id for rt1015p
On 2/25/21 8:05 PM, jack.yu@realtek.com wrote:
From: Jack Yu jack.yu@realtek.com
Add acpi device id for rt1015p.
Signed-off-by: Jack Yu jack.yu@realtek.com
sound/soc/codecs/rt1015p.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
diff --git a/sound/soc/codecs/rt1015p.c b/sound/soc/codecs/rt1015p.c index 671f2a2130fe..61694de080e6 100644 --- a/sound/soc/codecs/rt1015p.c +++ b/sound/soc/codecs/rt1015p.c @@ -4,6 +4,7 @@ // // Copyright 2020 The Linux Foundation. All rights reserved.
+#include <linux/acpi.h> #include <linux/delay.h> #include <linux/device.h> #include <linux/err.h> @@ -130,10 +131,19 @@ static const struct of_device_id
rt1015p_device_id[] = {
MODULE_DEVICE_TABLE(of, rt1015p_device_id); #endif
+#ifdef CONFIG_ACPI +static const struct acpi_device_id rt1015p_acpi_match[] = {
- { "ALCP1015", 0},
This isn't much better, ALC is not a vendor ID as defined by https://uefi.org/PNP_ACPI_Registry
I've ask for guidance from Intel ACPI folks on this, please stay tuned.
Hi Pierre,
Is there any update from Intel ACPI team regarding to this ID format issue?
BR, Jack
- { },
+}; +MODULE_DEVICE_TABLE(acpi, rt1015p_acpi_match); #endif
- static struct platform_driver rt1015p_platform_driver = { .driver = { .name = "rt1015p", .of_match_table = of_match_ptr(rt1015p_device_id),
.acpi_match_table = ACPI_PTR(rt1015p_acpi_match),------Please consider the environment before printing this e-mail.