Re: [PATCH v3 01/10] Add auxiliary bus support

On Thu, Nov 05, 2020 at 01:19:09AM -0800, Dan Williams wrote:

Some doc fixups, and minor code feedback. Otherwise looks good to me.

On Thu, Oct 22, 2020 at 5:35 PM Dave Ertman david.m.ertman@intel.com wrote:

...

<...>

...

+config AUXILIARY_BUS

•   bool
  

tristate? Unless you need non-exported symbols, might as well let this be a module.

I asked it to be "bool", because bus as a module is an invitation for a disaster. For example if I compile-in mlx5 which is based on this bus, and won't add auxiliary_bus as a module to initramfs, the system won't boot.

<...>

Per above SPDX is v2 only, so...

Isn't it default for the Linux kernel?

MODULE_LICENSE("GPL v2");

Thanks