Re: [PATCH v0 42/42] notifier: Return an error when callback is already registered

On Mon, Nov 08, 2021 at 05:12:16PM +0100, Geert Uytterhoeven wrote:

Returning void is the other extreme ;-)

There are 3 levels (ignoring BUG_ON()/panic () inside the callee):

1. Return void: no one can check success or failure,
2. Return an error code: up to the caller to decide,
3. Return a __must_check error code: every caller must check.

I'm in favor of 2, as there are several places where it cannot fail.

Makes sense to me. I'll do that in the next iteration.

Thx.