Re: [PATCH 6/8] ASoC: rt5682: Support dbvdd and ldo1-in supplies

31 Oct 2022


      On Mon, Oct 31, 2022 at 01:09:28PM +0000, Mark Brown wrote:
...
On Fri, Oct 28, 2022 at 04:55:38PM -0400, Nícolas F. R. A. Prado wrote:
...
@@ -35,6 +35,8 @@ const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] = {
   "AVDD",
   "MICVDD",
   "VBAT",

"dbvdd",
"ldo1-in",

Why are we making these inconsistent in style with the other supplies?
In short because the other supplies already have users while these are new ones.
My understanding was that new supplies should have lowercase names, following DT
convention. But I do see the argument on having them all be consistent for a
single driver/binding. If there are no remarks from Rob or Krzysztof I can
change it in the next version.
Thanks,
Nícolas

    