On Fri, Dec 13, 2019 at 05:25:23PM -0600, Pierre-Louis Bossart wrote:
No, I mean the new MODULE_NAMESPACE() support that is in the kernel. I'll move the greybus code to use it too, but when you are adding new apis, it just makes sense to use it then as well.
Greg, would the patch below be what you had in mind? Thanks -Pierre
diff --git a/drivers/soundwire/Makefile b/drivers/soundwire/Makefile index 76a5c52b12b4..5bad8422887e 100644 --- a/drivers/soundwire/Makefile +++ b/drivers/soundwire/Makefile @@ -7,9 +7,11 @@ ccflags-y += -DDEBUG #Bus Objs soundwire-bus-objs := bus_type.o bus.o master.o slave.o mipi_disco.o stream.o obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o +ccflags-$(CONFIG_SOUNDWIRE) += -DDEFAULT_SYMBOL_NAMESPACE=SDW_CORE
soundwire-generic-allocation-objs := generic_bandwidth_allocation.o obj-$(CONFIG_SOUNDWIRE_GENERIC_ALLOCATION) += soundwire-generic-allocation.o +ccflags-$(CONFIG_SOUNDWIRE_GENERIC_ALLOCATION) += -DDEFAULT_SYMBOL_NAMESPACE=SDW_CORE
Don't use ccflags, just use the correct MODULE_EXPORT_NS() tag instead.
And "SDW_CORE" is odd, "SOUNDWIRE" instead?
thanks,
greg k-h