-----Original Message----- From: dgreid@google.com [mailto:dgreid@google.com] On Behalf Of Dylan Reid Sent: Tuesday, May 05, 2015 3:43 PM To: Fang, Yang A Cc: Mark Brown; alsa-devel@alsa-project.org; Sripathi, Srinivas; Koul, Vinod; Jain, Praveen K; Liam Girdwood; Iriawan, Denny; Nujella, Sathyanarayana; kevin.strasser@linux.intel.com; Bard Liao Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Enabled button jack for BSW platform with rt5650 codec
On Tue, May 5, 2015 at 3:39 PM, Fang, Yang A yang.a.fang@intel.com wrote:
-----Original Message----- From: Mark Brown [mailto:broonie@kernel.org] Sent: Tuesday, May 05, 2015 3:30 PM To: Fang, Yang A Cc: Dylan Reid; alsa-devel@alsa-project.org; Sripathi, Srinivas; Koul, Vinod; Jain, Praveen K; Liam Girdwood; Iriawan, Denny; Nujella, Sathyanarayana; kevin.strasser@linux.intel.com Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: Enabled button jack for BSW platform with rt5650 codec
On Tue, May 05, 2015 at 03:14:15PM -0700, Yang Fang wrote:
now rt5645_set_jack_detect in rt5645.c aleady split jack into 3 like below. maybe we need Bard to combine them ?
It's fine to do that in the CODEC driver and actually good for the headphone and microphone - the board can always pass in the same jack for all of them but if it does have split headphone and mic jacks then it can
do that.
Thanks. I will post v2 after Bard modifies the api
If I'm interpreting Mark's comment correctly, he is suggesting that the API remain the same and have cht_bsw_rt5645.c pass the same jack to all three parameters. I like this idea, as unlike the 227e driver the 5650 could be used with separate hp and mic jacks. I'd imagine there wouldn't be a button jack in that case since that is headset specific, but that shouldn't matter.
Ok will try to pass same jack from the board file
Yang