Re: [v4 16/18] dt-bindings: mediatek: mt8186: add mt8186-mt6366-da7219-max98357 document

On Thu, 2022-04-28 at 09:31 -0500, Rob Herring wrote:

On Thu, Apr 28, 2022 at 05:33:53PM +0800, Jiaxin Yu wrote:

...

Add document for mt8186 board with mt6366, da7219 and max98357.

Signed-off-by: Jiaxin Yu jiaxin.yu@mediatek.com

.../sound/mt8186-mt6366-da7219-max98357.yaml | 71 +++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/mt8186- mt6366-da7219-max98357.yaml

diff --git a/Documentation/devicetree/bindings/sound/mt8186-mt6366- da7219-max98357.yaml b/Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219- max98357.yaml new file mode 100644 index 000000000000..55e8649f2aea --- /dev/null +++ b/Documentation/devicetree/bindings/sound/mt8186-mt6366-da7219- max98357.yaml @@ -0,0 +1,71 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/mt8186-mt6366-da7219-max98357.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Mediatek MT8186 with MT6366, DA7219 and MAX98357 ASoC sound card driver

+maintainers:

• • Jiaxin Yu jiaxin.yu@mediatek.com

+description:

• This binding describes the MT8186 sound card.

+properties:

• compatible:
• enum:

•  - mediatek,mt8186_mt6366_da7219_max98357_sound
  

s/_/-/

Got it.

...

• mediatek,platform:
• $ref: "/schemas/types.yaml#/definitions/phandle"
• description: The phandle of MT8186 ASoC platform.
• headset-codec:
• type: object

   additionalProperties: false

Ditto.

...

• properties:

•  sound-dai:
  

•    $ref: /schemas/types.yaml#/definitions/phandle
  

sound-dai already has a type, so drop and define how many entries.

Ditto.

...

• required:

•    - sound-dai
  

The indentation of this line is incorrect. I will fix it.

...

• playback-codecs:
• type: object

   additionalProperties: false

Got it.

...

• properties:

•  sound-dai:
  

•    minItems: 2
  

•    maxItems: 3
  

If more than 1 entry, then you need to define what each one is and the order. Just like reg, interrupts, clocks, etc.

Hi Rob,

Should I correct them as below?

--- properties: sound-dai: minItems: 2 maxItems: 3 items: - items: - description: xxx - description: yyy - description: zzz

...

•    $ref: /schemas/types.yaml#/definitions/phandle-array
  

Drop

Got it.

...

• required:

•    - sound-dai
  

+additionalProperties: false

+required:

• • compatible
• • mediatek,platform
• • headset-codec
• • playback-codecs

+examples:

• • |
• sound: mt8186-sound {

•    compatible =
  

"mediatek,mt8186_mt6366_da7219_max98357_sound";

•    mediatek,platform = <&afe>;
  

•    pinctrl-names = "aud_clk_mosi_off",
  

•                    "aud_clk_mosi_on";
  

•    pinctrl-0 = <&aud_clk_mosi_off>;
  

•    pinctrl-1 = <&aud_clk_mosi_on>;
  

•    headset-codec {
  

•        sound-dai = <&da7219>;
  

•    };
  

•    playback-codecs {
  

•        sound-dai = <&anx_bridge_dp>,
  

•                    <&max98357a>;
  

•    };
  

• };

+...

2.25.1