On Mon, 06 Feb 2017 22:54:59 +0100, Andrej Kruták wrote:
On Mon, Feb 6, 2017 at 10:19 PM, Takashi Iwai tiwai@suse.de wrote:
On Mon, 06 Feb 2017 20:34:58 +0100, Andrej Krutak wrote:
While not all line6 devices currently support PCM, it causes no harm to 'have it prepared'.
This also fixes toneport, which only has PCM - in which case we previously skipped the USB transfer properties detection completely.
Signed-off-by: Andrej Krutak dev@andree.sk
Well, this looks too complex and vague as a regression fix. If it were 4.10-rc1, I could take it. But now it's already rc7 and the next might be final, so I prefer a shorter and easier solution.
In the end, the patch is just "careful", so that the endpoint structures are not read if the devices is not "marked" as having them.
Yes, but it's still not very clear what actually "fixes".
That said, we can revert the commit as a clear fix at first for 4.10 (with Cc to stable), then take this on top as an enhancement for 4.11.
Still it's important to know whether this works on Igor's system, so Igor, please give this one try.
Thanks to zero-init of toneport_properties_table, the proposed simple revert should be enough for toneport, and shouldn't break other devices (perhaps HD300-HD500 may start showing the dev_err from line6_get_interval()).
So do as you like - e.g. simple revert for 4.10 and apply this patch for 4.11. But I don't mind if you won't.... :-)
Yes, I now queued the revert patch to for-linus branch, and yours to for-next branch on top of it.
thanks,
Takashi