5 Mar
2009
5 Mar
'09
12:26 p.m.
On Thu, Mar 05, 2009 at 11:21:33AM +0000, Mark Brown wrote:
Shouldn't this be somehow set by set_dai_clkdiv instead?
This is actually a very common case - MCLK is BCLK*4, so I put it here. We could still move it to some more configurable place if it turns out we need to configure it per board.
It's a common option but far from universal - apart from anything else normally the MCLK requirement is a multiple of the sampling frequency rather than the bitclock rate so the ratio with BCLK will often vary with sample size. I've seen devices able to operate as low as 64fs and IIRC I've seen things up to 512fs, though 256fs is more common.
Ok, agreed. I moved that to my board file (using DIV_SCR) and will drop that piece in the next patches.
Daniel