Re: [alsa-devel] [PATCH RFC 2/8] ASoC: davinci-evm: Add device tree binding

On Mon, Sep 09, 2013 at 06:12:13PM +0300, oku@iki.fi wrote:

From: "Hebbar, Gururaja" gururaja.hebbar@ti.com

Device tree support for Davinci Machine driver

You need to send this to the device tree maintainers and the device tree mailing list (not the old one you CCed).

• Codec pins:
• • MIC3L
• • MIC3R
• • LINE1L
• • LINE2L
• • LINE1R
• • LINE2R

These should be documented in the binding for the CODEC and referenced here - if there isn't a binding for the CODEC you should add it.

• machine_ver = (u32)match->data;
• switch (machine_ver) {
• case MACHINE_VERSION_1:

• evm_dai.name		= "Voice Codec - CQ93VC";
  

• evm_dai.stream_name	= "CQ93";
  

• evm_dai.codec_dai_name	= "cq93vc-hifi";
  

• break;
  

• case MACHINE_VERSION_2:

• evm_dai.ops = &evm_ops;
  

• evm_dai.init = evm_aic3x_init;
  

• break;
  

• }

This appears to have binndings for two completely different CODECs...