At Mon, 13 Oct 2008 17:38:34 +0100, Mark Brown wrote:
Since Kconfig ignores dependencies on select and other users should select SND_SOC_TLV320AIC26 we can add a dependency on the OpenFirmware helper to avoid exposing the menu entry to users who can't benefit from it.
Hmm, I'm afraid this may disable CONFIG_SND_SOC_TLV320AIC26 when CONFIG_SND_SOC_OF_SIMPLE=n automatically, no?
Thanks to Takashi for the suggestion.
Actually I proposed a wrong solution. What I meant was the form using "if" instead of "depends on":
config SND_SOC_TLV320AIC26 tristate "TI TLV320AIC26 Codec support" if SND_SOC_OF_SIMPLE ...
In this way, the selectable item appears only when CONFIG_SND_SOC_OF_SIMPLE is set. The other dependencies remain as they are.
Takashi
Signed-off-by: Mark Brown broonie@opensource.wolfsonmicro.com
sound/soc/codecs/Kconfig | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 4975d85..9242889 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -70,6 +70,9 @@ config SND_SOC_TLV320AIC23 config SND_SOC_TLV320AIC26 tristate "TI TLV320AIC26 Codec support" depends on SPI
- # Note the Kconfig doesn't enforce dependencies - this just
- # prevents non-OF users seeing the tristate in menus.
- depends on SND_SOC_OF_SIMPLE
config SND_SOC_TLV320AIC3X tristate -- 1.5.6.5