Re: [alsa-devel] [PATCH v2 2/2] ASoC: arizona: Add signal activity output for DRC

On Wed, Jul 03, 2013 at 01:38:46PM +0100, Charles Keepax wrote:

+ switch (arizona->type) { + case WM5110: + snd_soc_dapm_disable_pin(&codec->dapm, "DRC2 Signal Activity"); + /* Intentional fall through */ + default: + snd_soc_dapm_disable_pin(&codec->dapm, "DRC1 Signal Activity"); + break; + }

The comment there is a sign that you probably should've written this a bit differently :) - I'd just make the DRC1 disable unconditional and then people reading this don't need to think about why there's an intentional fall through.