RE: [PATCH] ASoC: Intel: boards: Add CML_RT1015 m/c driver

Was this patch shared on the mailing list? I don't see it in my inbox and in the archives?

At any rate, I am not hot on adding yet another machine driver just to change an amplifier version. It's really horrible to maintain all of these permutations by code duplication.

Adding a variant in a existing machine driver is a much better idea, and pretty much all new machine drivers follow this model. You could either rename the existing driver as cml_rt101x_rt5682 or use sof_rt5682.

Thanks -Pierre

+ Jimmy from google

Hi Jimmy, Any opinion about CML machine drivers for Chromebooks?

We may keep the separated driver in CHROMIUM or modify existing Helios driver to adopt the architecture in sof_rt5682 to work with multiple amps.

Regards, Brent