Re: [alsa-devel] [PATCH 2/4] ASoc: kirkwood: simplify probe error

On Thu, 25 Jul 2013 20:10:59 +0100 Mark Brown broonie@kernel.org wrote:

On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote:

...

The function kirkwood_i2s_dev_remove() may be used when probe fails.

This seems fine but doesn't apply against current code but otherwise seems fine.

My base is 3.11-rc2.

...

• if (!IS_ERR(priv->extclk)) {

• clk_disable_unprepare(priv->extclk);
  

• clk_put(priv->extclk);
  

• }

Could use devm_clk_get() for extclk.

I will do it.