On Thu, Jun 16, 2022 at 03:26:45PM -0500, David Owens wrote:
Convert to managed versions of sysfs and clk allocation to simplify unbinding and error handling in probe. Managed sysfs node creation specifically addresses the following error seen the second time probe is attempted after sdma_pcm_platform_register() previously requested probe deferral:
This breaks an x86 allmodconfig build:
In file included from /build/stage/linux/include/linux/kobject.h:20, from /build/stage/linux/include/linux/module.h:21, from /build/stage/linux/sound/soc/ti/omap-mcbsp.c:12: /build/stage/linux/sound/soc/ti/omap-mcbsp.c:604:18: error: ‘additional_groups’ defined but not used [-Werror=unused-variable] 604 | ATTRIBUTE_GROUPS(additional); | ^~~~~~~~~~ /build/stage/linux/include/linux/sysfs.h:154:38: note: in definition of macro ‘__ATTRIBUTE_GROUPS’ 154 | static const struct attribute_group *_name##_groups[] = { \ | ^~~~~ /build/stage/linux/sound/soc/ti/omap-mcbsp.c:604:1: note: in expansion of macro ‘ATTRIBUTE_GROUPS’ 604 | ATTRIBUTE_GROUPS(additional); | ^~~~~~~~~~~~~~~~ In file included from /build/stage/linux/include/linux/kobject.h:20, from /build/stage/linux/include/linux/module.h:21, from /build/stage/linux/sound/soc/ti/omap-mcbsp-st.c:12: /build/stage/linux/sound/soc/ti/omap-mcbsp-st.c:299:18: error: ‘sidetone_groups’ defined but not used [-Werror=unused-variable] 299 | ATTRIBUTE_GROUPS(sidetone); | ^~~~~~~~ /build/stage/linux/include/linux/sysfs.h:154:38: note: in definition of macro ‘__ATTRIBUTE_GROUPS’ 154 | static const struct attribute_group *_name##_groups[] = { \ | ^~~~~ /build/stage/linux/sound/soc/ti/omap-mcbsp-st.c:299:1: note: in expansion of macro ‘ATTRIBUTE_GROUPS’ 299 | ATTRIBUTE_GROUPS(sidetone); | ^~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors