18 Apr
2013
18 Apr
'13
5:56 p.m.
On Thu, Apr 18, 2013 at 04:43:43PM +0200, Lars-Peter Clausen wrote:
On 04/18/2013 02:33 PM, Markus Pargmann wrote:
- if (pdev->dev.platform_data)
pdev->dev.of_node = pdev->dev.platform_data;
In my opinion it's better to use pdev->dev.parent->of_node here. In the ssi driver you use platform_device_register_data, which will create a copy of the of_node you pass in as platform data. I'm not quite sure how well this will work. If you want to continue to use platform_data you should at least change the code in the ssi driver to not make a copy of the of_node.
If nothing else the above code just looks wrong and confusing.