Re: [PATCH v3] ASoC: rt1318: Add RT1318 audio amplifier driver

On Wed, Jun 19, 2024 at 05:53:42AM +0000, Jack Yu wrote:

This is the initial i2s-based amplifier driver for rt1318.

Signed-off-by: Jack Yu jack.yu@realtek.com

include/sound/rt1318.h | 16 + sound/soc/codecs/Kconfig | 5 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/rt1318.c | 1354 +++++++++++++++++++++++++++++++++++++ sound/soc/codecs/rt1318.h | 342 ++++++++++ 5 files changed, 1719 insertions(+) create mode 100644 include/sound/rt1318.h create mode 100644 sound/soc/codecs/rt1318.c create mode 100644 sound/soc/codecs/rt1318.h

[...]

+static const struct of_device_id rt1318_of_match[] = {

• { .compatible = "realtek,rt1318", },

This is not documented. Please add a DT binding schema for it.

Rob