On 5/2/19 11:39 PM, Mark Brown wrote:
On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote:
config REGMAP_SOUNDWIRE tristate
- depends on SOUNDWIRE_BUS
- select SOUNDWIRE_BUS
This now makes _SOUNDWIRE different to all the other bus types; if this is a good change then surely the same thing should be done for all the other bus types. It's also not clear to me that this actually does anything, do selects from symbols that are themselves selected actually do anything?
yes, this works, but if you prefer alignment I can follow the SLIMBUS model
config SND_SOC_WCD9335 tristate "WCD9335 Codec" depends on SLIMBUS select REGMAP_SLIMBUS select REGMAP_IRQ
config REGMAP_SLIMBUS tristate depends on SLIMBUS
menuconfig SLIMBUS tristate "SLIMbus support" if SLIMBUS
# SLIMbus controllers config SLIM_QCOM_CTRL ...
As I mentioned it'll compile the bus even if there is no user for it, but it's your call: alignment or optimization.