On 18/12/2023 10:49, Elinor Montmasson wrote:
Hello,
Add documentation about new dts bindings following new support for compatible "fsl,imx-audio-generic".
Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching.
I saw that most of the commits use "ASoC: dt-bindings:" prefix, but
This one, plEASE.
commits related to "fsl-asoc-card.txt" use "ASoC: bindings:" prefix. Should I follow the general style or the file style ?
General style.
...
The compatible list for this generic sound card currently: @@ -48,6 +51,8 @@ The compatible list for this generic sound card currently:
"fsl,imx-audio-nau8822"
- "fsl,imx-audio-generic"
Generic does not look like hardware specific.
Even if our end goal is to use it with the S/PDIF controller, this new support can be used with different hardware that doesn't require a codec. Thus, we don't really want to specify "spdif" in it.
Is this compatible string not suitable ? Should we rename it to something else, like "fsl,imx-audio-no-codec" ?
Maybe Mark or Rob will help here, but for me "imx-audio" is just way too generic.
Also, you add several new properties, so I really expect either converting old binding to DT schema first or adding new device in DT schema format.
Best regards, Krzysztof