Re: [alsa-devel] [PATCH v5 02/12] ASoC: davinci-evm: Add device tree binding

On Fri, Oct 18, 2013 at 06:37:41PM +0300, Jyri Sarha wrote:

• TLV320AIC3X pins:
• • LLOUT
• • RLOUT
• • MONO_LOUT
• • HPLOUT
• • HPROUT
• • HPLCOM
• • HPRCOM
• • MIC3L
• • MIC3R
• • LINE1L
• • LINE2L
• • LINE1R
• • LINE2R

These should be documented in the CODEC binding and not in the card driver, that way this doesn't need to be replicated in every machine and any future software compatible devices can just work with the existing binding.

• ret = snd_soc_register_card(&evm_soc_card);

This should be using devm_snd_soc_register_card().

• /*

• * If dtb is there, the devices will be created dynamically.
  

• * Only register platfrom driver structure.
  

• */
  

• if (of_have_populated_dt())

• return platform_driver_register(&davinci_evm_driver);
  

Why not register the driver unconditionally?