Re: [alsa-devel] [PATCH 3/7] ALSA: hda - use dell_micmute_led_set() instead of dell_app_wmi_led_set()

On Thursday 08 December 2016 13:36:14 Michał Kępień wrote:

...

--- a/sound/pci/hda/dell_wmi_helper.c +++ b/sound/pci/hda/dell_wmi_helper.c @@ -6,7 +6,7 @@ #include <linux/dell-led.h>

static int dell_led_value; -static int (*dell_led_set_func)(int, int); +static int (*dell_led_set_func)(int);

Suggestion: what about changing name to dell_micmute_led_set_func to match real function name which is used after this patch?

While I like the idea itself, implementing it will double the number of lines that this patch changes (6 vs. 12), arguably making its intention less clear. Please let me know if you would really like this to happen (perhaps as a separate patch?), otherwise I will skip this idea in v2.