On Tue, Oct 08, 2013 at 10:34:13AM +0100, Mark Brown wrote:
On Tue, Oct 08, 2013 at 10:29:33AM +0200, Markus Pargmann wrote:
To make proper error handling and only STOP functions that successfully started, we have to store the state of each function. The command error handling is done in pcm_native.c so we don't have any influence on that.
I meant just unwinding the things done in the trigger call.
You mean unwinding when we detect the error? If we return the error code from the trigger function, the pcm_native.c will still trigger a STOP command which is executed on all components.
Another possibility is to explicitly allow multiple _STOPs. Then I could fix the driver to store the clock state. But I would prefer a generic solution.
You're going to have to handle this anyway to be robust - what happens if it's the clock enable that fails?
If clk_enable fails, we can return an error code in the mxs-saif trigger function. Of course the error handling is missing here, but it is not necessary to store the state of the clock to handle errors properly.
Regards,
Markus