Hi,
Answer in line.
From: Takashi Iwai tiwai@suse.de Sent: 13 August 2025 23:44 To: Xu, Baojun Cc: broonie@kernel.org; andriy.shevchenko@linux.intel.com; alsa-devel@alsa-project.org; Ding, Shenghao; 13916275206@139.com; linux-sound@vger.kernel.org; linux-kernel@vger.kernel.org Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Normalize the volume kcontrol name
On Wed, 13 Aug 2025 12:08:42 +0200, Baojun Xu wrote:
Change the name of the kcontrol from "Gain" to "Volume".
Could you describe "why this change is needed"?
This name is in kcontrol, which is open to users. Volume is more normalized and common. Gain is a more professional term in smart amplifiers.
thanks,
Takashi
Signed-off-by: Baojun Xu baojun.xu@ti.com
sound/hda/codecs/side-codecs/tas2781_hda_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c index 92aae19cfc8f..e4bc3bc756b0 100644 --- a/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c +++ b/sound/hda/codecs/side-codecs/tas2781_hda_i2c.c @@ -256,7 +256,7 @@ static const struct snd_kcontrol_new tas2770_snd_controls[] = { };
static const struct snd_kcontrol_new tas2781_snd_controls[] = {
ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Gain", TAS2781_AMP_LEVEL,
ACARD_SINGLE_RANGE_EXT_TLV("Speaker Analog Volume", TAS2781_AMP_LEVEL, 1, 0, 20, 0, tas2781_amp_getvol, tas2781_amp_putvol, amp_vol_tlv), ACARD_SINGLE_BOOL_EXT("Speaker Force Firmware Load", 0,-- 2.43.0
Best Regards Jim