Re: [alsa-devel] [PATCH 3/3] ASoC: mxs: add some error messages to help identifying problems

On Wed, Jul 31, 2013 at 07:11:48PM -0300, Fabio Estevam wrote:

On Wed, Jul 31, 2013 at 11:44 AM, Lothar Waßmann LW@karo-electronics.de wrote:

...

    /* Set SGTL5000's SYSCLK (provided by SAIF MCLK) */
    ret = snd_soc_dai_set_sysclk(codec_dai, SGTL5000_SYSCLK, mclk, 0);

•   if (ret)
  

•   if (ret) {
  

•           dev_err(codec_dai->dev, "Failed to set sysclk to %u kHz\n",
  

•                   mclk / 1000);
  

Wouldn't it make more sense to express it in MHz instead of kHz?

Well, ideally it'd be fractional MHz (ie, 24.576MHz). I'd either leave it as Hz or do the proper pretty print. Also if we're nitpicking the format then there's usually no space between the number and units.

Personally I think the bike shed would be most attractive if it were pink with yellow spots.