On Wed, 15 Apr 2009 14:38:55 +0200 "Ujfalusi Peter (Nokia-D/Tampere)" peter.ujfalusi@nokia.com wrote:
Use single-phase mode for the DSP mode and keep the dual phase mode for the I2S mode.
The mono (1 channel) mode already used single phase mode, now it is more cleaner. There is no need to configure the second phase, when the single phase is used.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@nokia.com
I did a little bit of hacking and testing with this to see are can this even be a fix on top of my DSP_B fix for 2.6.30 but looks like there is no currently any difference or potential bug fix are we using single or dual phase mode for stereo samples. For testing I hacked to use word length of 20-bits (only the interface, not samples) and both phase modes produced the same bit stream.
But as this is more generic case and only option for multichannel configuration let's start to use it and let only I2S to continue use the dual-phase mode.
Acked-by: Jarkko Nikula jarkko.nikula@nokia.com