On Mon, 22 Jun 2020 10:42:36 -0500, Pierre-Louis Bossart wrote:
While looking at reboot issues and module load/unload tests, I found out some resources allocated in the dailink .init() callback are not properly released - there is no existing mechanism in the soc-core to do so.
The addition of a dailink .exit() callback seems to be the simplest solution overall. It can be argued that the existing machine platform device .remove() callback can also perform the necessary cleanups, however as shown in the last two examples this might require a loop to identify components whereas the dailink .exit() already has all the necessary information to revert the actions done in the .init() step.
[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/5] ASoC: soc-link: introduce exit() callback commit: 21a00fb33790f828a34b9ce50ab9f9130bc1ffb4 [2/5] ASoC: Intel: bdw-rt5677: fix module load/unload issues commit: bcb43fdae1c0d08b772b792cf46f323ad0d17968 [3/5] ASoC: Intel: kbl-rt5660: use .exit() dailink callback to release gpiod commit: e56054e75325c347f09c1be2f6400ef67bb9662d [4/5] ASoC: intel: sof_rt5682: move disabling jack to dai link's exit() commit: b0c96fc1ab2947e331f817cecc5ca733eaf5619b [5/5] ASoC: intel: cml_rt1011_rt5682: disable jack in dailink .exit() commit: 4fcc922cb31179f9bc1e99cd707f2b36138fbcf8
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks, Mark