Re: [PATCH v5 2/8] arm64: dts: qcom: sc7280: Add sound node for crd-rev3 board

On 06/02/2023 17:16, Srinivasa Rao Mandadapu wrote:

Add sound node for sc7280 ADSP based audioreach platforms such as crd-rev3 board.

Include audioreach dtsi into crd-rev3 platform specific dts file. Also remove phandle to sound node, as audio routing is same as audioreach specific dtsi file.

Signed-off-by: Srinivasa Rao Mandadapu quic_srivasam@quicinc.com Tested-by: Mohammad Rafi Shaik quic_mohs@quicinc.com

Thank you for your patch. There is something to discuss/improve.

+/{

• /* BOARD-SPECIFIC TOP LEVEL NODES */
• sound: sound {

• compatible = "google,sc7280-herobrine";
  

• model = "AR-wcd938x-max98360a-1mic";
  

• audio-routing =
  

• 	"IN1_HPHL", "HPHL_OUT",
  

• 	"IN2_HPHR", "HPHR_OUT",
  

• 	"AMIC1", "MIC BIAS1",
  

• 	"AMIC2", "MIC BIAS2",
  

• 	"VA DMIC0", "MIC BIAS1",
  

• 	"VA DMIC1", "MIC BIAS1",
  

• 	"VA DMIC2", "MIC BIAS3",
  

• 	"VA DMIC3", "MIC BIAS3",
  

• 	"TX SWR_ADC0", "ADC1_OUTPUT",
  

• 	"TX SWR_ADC1", "ADC2_OUTPUT",
  

• 	"TX SWR_ADC2", "ADC3_OUTPUT",
  

• 	"TX SWR_DMIC0", "DMIC1_OUTPUT",
  

• 	"TX SWR_DMIC1", "DMIC2_OUTPUT",
  

• 	"TX SWR_DMIC2", "DMIC3_OUTPUT",
  

• 	"TX SWR_DMIC3", "DMIC4_OUTPUT",
  

• 	"TX SWR_DMIC4", "DMIC5_OUTPUT",
  

• 	"TX SWR_DMIC5", "DMIC6_OUTPUT",
  

• 	"TX SWR_DMIC6", "DMIC7_OUTPUT",
  

• 	"TX SWR_DMIC7", "DMIC8_OUTPUT";
  

• #address-cells = <1>;
  

• #size-cells = <0>;
  

• #sound-dai-cells = <0>;
  

This line looks incorrect - drop dai cells.

• dai-link@0 {
  

Best regards, Krzysztof