Re: [alsa-devel] [PATCH] ASoC: atmel: add wm8904 based audio machine driver

On Fri, Jul 19, 2013 at 05:42:57PM +0800, Bo Shen wrote:

Add wm8904 based audio machine driver for Atmel EK board

Applied, thanks though...

• mclk = clk_get(NULL, "pck0");
• if (IS_ERR(mclk)) {

• dev_err(&pdev->dev, "failed to get pck0\n");
  

• ret = PTR_ERR(mclk);
  

• goto err_set_audio;
  

• }
• clk_src = clk_get(NULL, "clk32k");
• if (IS_ERR(clk_src)) {

• dev_err(&pdev->dev, "failed to get clk32k\n");
  

• ret = PTR_ERR(clk_src);
  

• goto err_set_audio;
  

• }

These should really be devm_clk_get()s and use a device. This can be revisited after the common clock framework conversion though.