On Mon, Jul 22, 2019 at 5:18 PM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
On 7/22/19 8:34 AM, Arnd Bergmann wrote:
On Mon, Jul 22, 2019 at 3:16 PM Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com wrote:
On 7/22/19 7:56 AM, Takashi Iwai wrote:
On Mon, 22 Jul 2019 14:49:34 +0200,
Our goal is to minimize the differences and allow deltas e.g. for license or comments. We could add a definition for __u32 when linux is not used, I am just not sure if these two files really fall in the UAPI category and if the checks make sense.
If you can build all the SOF user space without these headers being installed to /usr/include/sound/sof/, you can move them from include/uapi/sound/sof to include/sounds/sof and leave the types unchanged.
yes we don't need those files to build userspace stuff. The idea was that these format definitions establish a contract between userspace (more specifically the files stored in /lib/firmware) and the kernel. IIRC we wanted to make sure that any changes would be tracked as breaking userspace. If the consensus is that the uapi directory is strictly used for builds then we should indeed move those files
I don't see a problem with keeping the files in uapi for practical purposes, but then I think it makes sense to apply the same rules as for other uapi headers and use user-space clean type names.
Arnd