Re: [alsa-devel] [PATCH 2/2] ASoC: soc-core: add snd_soc_add_component()

Hi Daniel

...

...

...

•   component = kzalloc(sizeof(*component), GFP_KERNEL);
  

•   if (!component) {
  

•           dev_err(dev, "ASoC: Failed to allocate memory\n");
  

•           return -ENOMEM;
  

No need to print an error message if kzalloc fails. The core will print it.

Thanks. Yes I had noticed this warning from checkpatch. The main purpose of this patch is separate "register" function into "register" and "add". Thus, I keeped existing all code. I think "remove unneeded message" should be increment patch, but can you agree ?

Makes sense. It's better to be sent as a separate patch.

Thanks. If you have no objection, I will post it if this patch was accepted. Or do you do this ?

Best regards --- Kuninori Morimoto