10 Nov
2014
10 Nov
'14
2:23 p.m.
On 11/10/2014 12:51 PM, Mark Brown wrote:
On Mon, Nov 10, 2014 at 12:27:32PM +0200, Peter Ujfalusi wrote:
+static const struct soc_enum aic3x_pop_reduction_enum[] = {
- SOC_ENUM_SINGLE(HPOUT_POP_REDUCTION, 4, 12, aic3x_poweron_time),
- SOC_ENUM_SINGLE(HPOUT_POP_REDUCTION, 2, 4, aic3x_rampup_step),
+};
- /* Pop reduction */
- SOC_ENUM("Output Driver Power-On time", aic3x_pop_reduction_enum[0]),
- SOC_ENUM("Output Driver Ramp-up step", aic3x_pop_reduction_enum[1]),
Don't add arrays of enums with magic number indexes like this, it's hard to read and hence error prone.
I agree on this. I have not changed this since this driver is using enums like this and I thought it is better to follow the style.
But if I add these to the aic3x_enum[] array with a define for the ID I think it is going to be a bit better?
--
Péter