Re: [PATCH 03/25] dt-bindings: clock: meson: add A1 audio clock and reset controller bindings

On 15/03/2024 00:21, Jan Dakinevich wrote:

Signed-off-by: Jan Dakinevich jan.dakinevich@salutedevices.com

You must provide commit messages.

A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bi...

---

.../bindings/clock/amlogic,a1-audio-clkc.yaml | 83 ++++++++++++ .../dt-bindings/clock/amlogic,a1-audio-clkc.h | 122 ++++++++++++++++++ .../reset/amlogic,meson-a1-audio-reset.h | 29 +++++ 3 files changed, 234 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock/amlogic,a1-audio-clkc.yaml create mode 100644 include/dt-bindings/clock/amlogic,a1-audio-clkc.h create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-audio-reset.h

diff --git a/Documentation/devicetree/bindings/clock/amlogic,a1-audio-clkc.yaml b/Documentation/devicetree/bindings/clock/amlogic,a1-audio-clkc.yaml new file mode 100644 index 000000000000..c76cad4da493 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/amlogic,a1-audio-clkc.yaml @@ -0,0 +1,83 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/amlogic,a1-audio-clkc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Amlogic A1 Audio Clock Control Unit and Reset Controller

+maintainers:

• • Neil Armstrong neil.armstrong@linaro.org
• • Jerome Brunet jbrunet@baylibre.com
• • Jan Dakinevich jan.dakinevich@salutedevices.com

+properties:

• compatible:
• const: amlogic,a1-audio-clkc
• '#clock-cells':
• const: 1
• '#reset-cells':
• const: 1
• reg:
• minItems: 2

Drop

• maxItems: 2
• clocks:
• items:

•  - description: input main peripheral bus clock
  

•  - description: input dds_in
  

•  - description: input fixed pll div2
  

•  - description: input fixed pll div3
  

•  - description: input hifi_pll
  

•  - description: input oscillator (usually at 24MHz)
  

• clock-names:
• items:

•  - const: pclk
  

•  - const: dds_in
  

•  - const: fclk_div2
  

•  - const: fclk_div3
  

•  - const: hifi_pll
  

•  - const: xtal
  

+required:

• • compatible
• • '#clock-cells'
• • '#reset-cells'
• • reg
• • clocks
• • clock-names

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/clock/amlogic,a1-pll-clkc.h>
• #include <dt-bindings/clock/amlogic,a1-peripherals-clkc.h>
• audio {

•    #address-cells = <2>;
  

•    #size-cells = <2>;
  

•    clkc_audio: audio-clock-controller@0 {
  

•            compatible = "amlogic,a1-audio-clkc";
  

•            reg = <0x0 0xfe050000 0x0 0xb0>,
  

Messed indentayion. Use 4 spaces for example indentation.

•                  <0x0 0xfe054800 0x0 0x20>;
  

•            #clock-cells = <1>;
  

•            #reset-cells = <1>;
  

•            clocks = <&clkc_periphs CLKID_AUDIO>,
  

•                     <&clkc_periphs CLKID_DDS_IN>,
  

•                     <&clkc_pll CLKID_FCLK_DIV2>,
  

•                     <&clkc_pll CLKID_FCLK_DIV3>,
  

•                     <&clkc_pll CLKID_HIFI_PLL>,