29 Mar
2013
29 Mar
'13
11:53 a.m.
On Thu, Mar 28, 2013 at 05:53:10PM -0600, Stephen Warren wrote:
Mark, the goto here might be considered icky. It avoids heavy indent levels. Should I separate out the control creation part of dapm_new_mixer() into a separate function to avoid this?
I think the fact that you're asking this question means you know the answer :)
Also, this commit has the potential for user-space impact, since control names could change for existing drivers. However, in this case I suspect the affected controls wouldn't have worked very well anyway, since they'd be affected by one of the problems I mention in the commit description above anyway, so I doubt this will be a practical problem.
This isn't a big deal.