Re: [alsa-devel] [PATCH v4 2/2] ac3dec: Show usage if no parameter is passed

At Tue, 13 Nov 2012 10:08:14 -0200, Fabio Estevam wrote:

When ac3dec is called without any argument the application hangs forever.

Instead of hanging, print the usage and exit.

Signed-off-by: Fabio Estevam fabio.estevam@freescale.com

Thanks, applied.

Takashi

---

Changes since v3:

• Fix return value

Changes since v2:

• No changes

Changes since v1:

• Also check for isatty, so that 'ac3dec < file.wav' can still work

ac3dec/ac3dec.c | 5 +++++ 1 file changed, 5 insertions(+)

diff --git a/ac3dec/ac3dec.c b/ac3dec/ac3dec.c index 00c4f1a..ce6c507 100644 --- a/ac3dec/ac3dec.c +++ b/ac3dec/ac3dec.c @@ -130,6 +130,11 @@ int main(int argc,char *argv[]) out_config.spdif = SPDIF_NONE; out_config.hdmi = 0;

• if (isatty(fileno(stdin)) && (argc == 1)) {

• help();
  

• return 1;
  

• }
• morehelp = 0; while (1) { int c;

-- 1.7.9.5