Dear Mark,
On 18-05-17 18:08, Mark Brown wrote:
On Thu, May 17, 2018 at 03:55:18PM +0200, Marco Felsch wrote:
+++ b/sound/soc/codecs/ssm2305.c @@ -0,0 +1,104 @@ +// SPDX-License-Identifier: GPL-2.0 +/*
- Analog Devices SSM2305 Amplifier Driver
Please submit a followup patch which makes the entire comment a C++ one rather than mixing them in the same comment block, it makes things look more intentional.
I'm a bit confused. As documented by the Documentation/process/license-rules.rst the license header should be a C++ comment but for all block comments the 'normal' coding style should be applied. I can seperate the license header and the comment to make it more intentional.
// SPDX-License-Identifier: GPL-2.0
/* * Analog Devices SSM2305 Amplifier Driver * * Copyright (C) 2018 Pengutronix, Marco Felsch kernel@pengutronix.de */
Is that better?
Marco