Re: [PATCH 18/25] ASoC: component: Add generic PCM copy ops

On Mon, Aug 14, 2023 at 01:55:16PM +0200, Takashi Iwai wrote:

For following the ALSA PCM core change, a new PCM copy ops is added toe ASoC component framework: snd_soc_component_driver receives the copy ops, and snd_soc_pcm_component_copy() helper is provided.

This also fixes a long-standing potential bug where the ASoC driver covers only copy_user PCM callback and misses the copy from kernel pointers (such as OSS PCM layer), too.

As of this patch, the old copy_user is still kept, but it'll be dropped later after all drivers are converted.

...

• /* FIXME. it returns 1st copy now */
• for_each_rtd_components(rtd, i, component)

• if (component->driver->copy)
  

• 	return soc_component_ret(
  

• 		component,
  

This can be on the previous line.

• 		component->driver->copy(
  

• 			component, substream, channel,
  

Ditto for the component parameter.

• 			pos, buf, bytes));