Re: [PATCH v3 02/20] ASoC: fsl_micfil: Drop unused register read

On Tue, Apr 5, 2022 at 4:00 PM Sascha Hauer s.hauer@pengutronix.de wrote:

In get_pdm_clk() REG_MICFIL_CTRL2 is read, but the result is never used. Drop the unused code.

Signed-off-by: Sascha Hauer s.hauer@pengutronix.de

Acked-by: Shengjiu Wang shengjiu.wang@gmail.com

Best Regards Wang Shengjiu

---

sound/soc/fsl/fsl_micfil.c | 3 --- 1 file changed, 3 deletions(-)

diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c index 64019d003784b..cf10c212d770d 100644 --- a/sound/soc/fsl/fsl_micfil.c +++ b/sound/soc/fsl/fsl_micfil.c @@ -148,12 +148,9 @@ static inline int get_pdm_clk(struct fsl_micfil *micfil, static inline int get_clk_div(struct fsl_micfil *micfil, unsigned int rate) {

•   u32 ctrl2_reg;
    long mclk_rate;
    int clk_div;
  
  

•   regmap_read(micfil->regmap, REG_MICFIL_CTRL2, &ctrl2_reg);
  

•   mclk_rate = clk_get_rate(micfil->mclk);
  
    clk_div = mclk_rate / (get_pdm_clk(micfil, rate) * 2);
  

-- 2.30.2