At Fri, 22 Feb 2008 12:26:59 +1300, Eliot Blennerhassett wrote:
Hi Takashi,
My boss has started asking how long is it going to take to get our driver into mainline. I.e. a list of things we need to do, that when all those items have been dealt with, then the driver is accepted. Is it possible to make such a list?
I think the all coding style issues have been already listed in out previous mails, even about pretty picky ones. What I personally still don't think good is the infrastructure of the driver - the separate mangament of asihpi and hpimod. This makes it hard to understand the code flow. But, if it's your inevitable requirement, we can keep this as is. So, try to clean up the code as much as you can do now, and then let's check and move to alsa-kernel tree.
My remaining concern is the further maintenance. If I understand correctly, you would like to maintain your driver code from the common code-base among difference OSes and convert to the linux native one via a script. This would be difficult to pick up the upstream changes. But, again, it's your choice. I'd just need to be careful about the further merge from you in order not to break the upstream changes...
thanks and regards
Eliot Blennerhassett www.audioscience.com
P.S. Heres a quote that I feel has some relevance:
Well, the merge is easy but the maintenance is not... :)
thanks,
Takashi