On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote:
dev_err(&pdev->dev, "could not get codec-reset GPIO\n");
dev_err(&pdev->dev, "could not get codec-reset GPIO: "
"%d\n", ret);Don't split strings over lines like this, it causes problems when people grep for errors. It's better to go over 80 columns.
OK, will do. However, in this case I did not actually split anything searchable anyway.
ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node, "nvidia,codec-sync- gpio", 0); if (!gpio_is_valid(ac97->sync_gpio)) {
dev_err(&pdev->dev, "no codec-sync GPIOsupplied\n");
ret = ac97->sync_gpio;dev_err(&pdev->dev, "no codec-sync GPIO supplied:%d\n", ret); goto err_clk_put; }
This isn't reporting an error code associated with the attempt to find a codec-sync GPIO, it's the result of some other operation.
What exactly is then the of_get_named_gpio() above please doing if not getting the codec sync GPIO? I am not following you, sorry.